Copying npm scripts for embedded node #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modifying the node-provided-npm to check for npm binary - Resolves eirslett#860, Resolves eirslett#458
|
Looks good to me, thanks! I guess it'll be in the christmas release! :-D |
|
There we go, 1.9.0 is released, merry christmas! 🎅 ❄️ 🎄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the "provided" npm version is used, the binaries are not copied into the node directory so they aren't in the path for
npmexecutions started from the plugin. For example, theprebuildin the example project callsnpm installwhich will use the system npm rather than that installed for the porject. This is experienced by reporters of #458 and #860.Tests and Documentation
Modified existing node-provided-npm integration test.
The example test is failing due to some phantomjs error and is apparently unrelated.